Use standard Node.js version in validation workflows #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These GitHub Actions workflows use the ajv-cli JSON schema validation tool to validate data files against their JSON schema. ajv-cli is an npm package-based tool. A standard major version of Node.js, and thus its bundled npm should be used for all development and maintenance operations. Previously, these workflows did not explicitly configure the version of Node.js that should be used in the runner machine, so whatever version happened to be installed in the runner by default was used. That version doesn't necessarily match with the intended version, and the version could change at any moment, so this risked instability in the project infrastructure.
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These GitHub Actions workflows use the ajv-cli JSON schema validation tool to validate data files against their JSON schema. ajv-cli is an npm package-based tool.
A standard major version of Node.js, and thus its bundled npm should be used for all development and maintenance operations. Previously, these workflows did not explicitly configure the version of Node.js that should be used in the runner machine, so whatever version happened to be installed in the runner by default was used. That version doesn't necessarily match with the intended version, and the version could change at any moment, so this risked instability in the project infrastructure.