RPC fixes #44
Merged
RPC fixes #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the logic for PWM configuration is not the usual one, the original commit was right
iabdalkader
reviewed
Jan 17, 2024
| #define VRING_BUFF_ADDRESS (SHM_START_ADDRESS + 0x2000) | ||
| #define VRING_BUFF_SIZE (SHM_SIZE - 0x2000) | ||
| #define VRING_ALIGNMENT 32 | ||
| #define VRING_NUM_BUFFS 16 /* number of rpmsg buffers */ |
There was a problem hiding this comment.
This has been updated to 64 buffers.
aentinger
added a commit
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs core 4.1.x (arduino/ArduinoCore-mbed@9bcf502) with RPC fixes by @iabdalkader