Skip to content

Discovered entries not supporting Arduino OTA are now filtered #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2022
+9 −0
Merged

Discovered entries not supporting Arduino OTA are now filtered #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ func (d *MDNSDiscovery) StartSync(eventCB discovery.EventCallback, errorCB disco
go func() {
for entry := range d.entriesChan {
port := toDiscoveryPort(entry)
if port == nil {
continue
}
if updated := d.portsCache.storeOrUpdate(port); !updated {
// Port is not cached so let the user know a new one has been found
eventCB("add", port)
Expand Down Expand Up @@ -189,6 +192,12 @@ func (d *MDNSDiscovery) StartSync(eventCB discovery.EventCallback, errorCB disco
}

func toDiscoveryPort(entry *mdns.ServiceEntry) *discovery.Port {
// Only entries that match the Arduino OTA service name must
// be returned
if !strings.HasSuffix(entry.Name, mdnsServiceName+".local.") {
return nil
}

ip := ""
if len(entry.AddrV4) > 0 {
ip = entry.AddrV4.String()
Expand Down