Allow specifying Arduino Lint ref for manual run of integration test #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
silvanocerza
approved these changes
Aug 10, 2021
When triggered automatically by a push, PR, or schedule event, the integration test uses the latest release of Arduino Lint. That is the same version used by the production engine, so appropriate for testing development on the engine. However, the integration of Arduino Lint into the engine should also be tested before a new version is released to be immediately used by the production engine. This will be made easier by allowing the integration test to be run via a manual trigger of GitHub Actions, specifying any arbitrary Git ref of the Arduino Lint repository to build from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When triggered automatically by a push, PR, or schedule event, the integration test uses the latest release of Arduino Lint. That is the same version used by the production engine, so appropriate for testing development on the engine.
However, the integration of Arduino Lint into the engine should also be tested before a new version is released to be immediately used by the production engine. This will be made easier by allowing the integration test to be run via a manual trigger of the GitHub Actions workflow, specifying any arbitrary Git ref of the Arduino Lint repository to build from.
Demonstration runs:
4674bc7e58ba4fc619d035274a54a570c35aa0cdas input: https://github.com/per1234/libraries-repository-engine/runs/3287322201?check_suite_focus=true#step:8:4mainas input: https://github.com/per1234/libraries-repository-engine/runs/3287298343?check_suite_focus=true#step:8:4