hotfix: Add hideWindow option to RunElevated on Windows
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a new WindowVisibility parameter to the RunElevated function on Windows, allowing callers to control whether the elevated process window is shown or hidden. Previously, the window was always hidden using SW_HIDE. The change introduces a new enum type with two options: WindowHidden and WindowShown, which are mapped to Windows show mode constants via a switch statement.
Key Changes:
- Introduced
WindowVisibilitytype withWindowHiddenandWindowShownconstants - Modified
RunElevatedfunction signature to accept avisibilityparameter - Replaced hardcoded
SW_HIDEwith dynamicshowModebased on the visibility parameter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lucarin91
reviewed
Dec 15, 2025
dido18
changed the title
hideWindow option to RunElevated on Windows
Xayton
approved these changes
Dec 15, 2025
dido18
changed the title
hideWindow option to RunElevated on WindowshideWindow option to RunElevated on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After #5, the executable is launched, and the terminal is hidden.
This change caused an issue with the AppLab update on Windows because the installer was launched with the 'hidden' attribute, so the user was unable to see it.
Changes
Add the
hideWindowparameter to theRunElevatedto specify whether to hide the executable launched.NOTE: This is a hotfix. The added boolean parameter introduces a not clear interface. We want to refactor it in a second moment.
Other resources