Skip to content

Add schema-based rules for platform data of package index #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Add schema-based rules for platform data of package index #200

merged 1 commit into from
Jun 28, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jun 24, 2021

These are the JSON schema-based rules to check the platform level data.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 24, 2021
@per1234 per1234 requested review from silvanocerza and umbynos June 24, 2021 00:05
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #200 (c1371a1) into main (9bdca8b) will increase coverage by 1.70%.
The diff coverage is 97.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   85.16%   86.87%   +1.70%     
==========================================
  Files          43       43              
  Lines        3391     3831     +440     
==========================================
+ Hits         2888     3328     +440     
  Misses        392      392              
  Partials      111      111              
Flag Coverage Δ
unit 86.87% <97.82%> (+1.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ternal/rule/ruleconfiguration/ruleconfiguration.go 100.00% <ø> (ø)
internal/rule/rulefunction/packageindex.go 96.10% <97.82%> (+6.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bdca8b...c1371a1. Read the comment docs.

These are the JSON schema-based rules to check the platform level data.
@per1234 per1234 merged commit 187ff13 into arduino:main Jun 28, 2021
@per1234 per1234 deleted the platform-schema-rules branch June 28, 2021 09:51
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants