Skip to content

Provide schema validation results in package index project data #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Provide schema validation results in package index project data #193

merged 1 commit into from
Jun 15, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jun 14, 2021

This allows the package index to be validated against its JSON schemas only once per project, with those results shared
between all the schema-based rules.

This allows the package index to be validated against its JSON schemas only once per project, with those results shared
between all the schema-based rules.
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 14, 2021
@per1234 per1234 requested review from silvanocerza and umbynos June 14, 2021 17:35
@codecov-commenter
Copy link

Codecov Report

Merging #193 (7a49563) into main (d7f669b) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   84.25%   84.23%   -0.02%     
==========================================
  Files          43       43              
  Lines        3207     3210       +3     
==========================================
+ Hits         2702     2704       +2     
- Misses        393      394       +1     
  Partials      112      112              
Flag Coverage Δ
unit 84.23% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/project/projectdata/packageindex.go 94.44% <66.66%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f669b...7a49563. Read the comment docs.

@per1234 per1234 merged commit ad3f06b into arduino:main Jun 15, 2021
@per1234 per1234 deleted the package-index-schema-validation-results branch June 15, 2021 08:14
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants