Skip to content

Fix corruption of incoming UTF-8-encoded serial data #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Fix corruption of incoming UTF-8-encoded serial data #1758

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6169b3
Fix corruption of incoming UTF-8-encoded serial data
palazzol Dec 8, 2022
f2108f4
Make TextDecoder() readonly because it can be
palazzol Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion arduino-ide-extension/src/node/monitor-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ export class MonitorService extends CoreClientAware implements Disposable {
private readonly board: Board;
private readonly port: Port;
private readonly monitorID: string;
private readonly streamingTextDecoder = new TextDecoder('utf8');

/**
* The lightweight representation of the port configuration currently in use for the running monitor.
Expand Down Expand Up @@ -319,7 +320,7 @@ export class MonitorService extends CoreClientAware implements Disposable {
const message =
typeof data === 'string'
? data
: new TextDecoder('utf8').decode(data);
: this.streamingTextDecoder.decode(data, {stream:true});
this.messages.push(...splitLines(message));
},
},
Expand Down