Skip to content

Update the background of a selected item in the sketchbook #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2022
Merged

Update the background of a selected item in the sketchbook #1190

merged 1 commit into from
Jul 15, 2022

Conversation

francescospissu
Copy link
Contributor

Motivation

The background of an element selected in the sketchbook needs to be updated.

Change description

Update CSS rule.

Before:
screenshot

After:
Screenshot 2022-07-14 165254

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@per1234 per1234 added the topic: code Related to content of the project itself label Jul 15, 2022
AlbyIanna
AlbyIanna approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It doesn't look great on High Contrast, but we'll probably have a discussion about that soon and solve it separately.

fstasi
fstasi approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@fstasi fstasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@francescospissu francescospissu merged commit 453a657 into main Jul 15, 2022
@francescospissu francescospissu deleted the sketchbook-item-bg branch July 15, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@91volt 91volt Awaiting requested review from 91volt

2 more reviewers

@fstasi fstasi fstasi approved these changes

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@francescospissu @fstasi @AlbyIanna @per1234