fix: terminate the process tree when stopping the daemon

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

arduino-ide-extension/src/node/arduino-daemon-impl.ts

@@ -16,7 +16,7 @@ import { ArduinoDaemon, NotificationServiceServer } from '../common/protocol';
 import { CLI_CONFIG } from './cli-config';
 import { getExecPath } from './exec-util';
 import { SettingsReader } from './settings-reader';
-// import { ProcessUtils } from '@theia/core/lib/node/process-utils';
+import { ProcessUtils } from '@theia/core/lib/node/process-utils';
 
 @injectable()
 export class ArduinoDaemonImpl
@@ -35,8 +35,8 @@ export class ArduinoDaemonImpl
   @inject(SettingsReader)
   private readonly settingsReader: SettingsReader;
 
-  // @inject(ProcessUtils)
-  // private readonly processUtils: ProcessUtils;
+  @inject(ProcessUtils)
+  private readonly processUtils: ProcessUtils;
 
   private readonly toDispose = new DisposableCollection();
   private readonly onDaemonStartedEmitter = new Emitter<string>();
@@ -89,8 +89,14 @@ export class ArduinoDaemonImpl
 
       this.toDispose.pushAll([
         Disposable.create(() => {
-          daemon.kill();
-          this.fireDaemonStopped();
+          if (daemon.pid) {
+            this.processUtils.terminateProcessTree(daemon.pid);
+            this.fireDaemonStopped();
+          } else {
+            throw new Error(
+              'The CLI Daemon process does not have a PID. IDE2 could not stop the CLI daemon.'
+            );
+          }
         }),
       ]);
       this.fireDaemonStarted(port);