Skip to content

Commit bd9f29c

Browse files
author
Akos Kitta
committed
test: revert daemon process tree kill
see if Windows tests are OK? Signed-off-by: Akos Kitta <[email protected]>
1 parent 9d5d53b commit bd9f29c

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

arduino-ide-extension/src/node/arduino-daemon-impl.ts

+5-11
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import { ArduinoDaemon, NotificationServiceServer } from '../common/protocol';
1616
import { CLI_CONFIG } from './cli-config';
1717
import { getExecPath } from './exec-util';
1818
import { SettingsReader } from './settings-reader';
19-
import { ProcessUtils } from '@theia/core/lib/node/process-utils';
19+
// import { ProcessUtils } from '@theia/core/lib/node/process-utils';
2020

2121
@injectable()
2222
export class ArduinoDaemonImpl
@@ -35,8 +35,8 @@ export class ArduinoDaemonImpl
3535
@inject(SettingsReader)
3636
private readonly settingsReader: SettingsReader;
3737

38-
@inject(ProcessUtils)
39-
private readonly processUtils: ProcessUtils;
38+
// @inject(ProcessUtils)
39+
// private readonly processUtils: ProcessUtils;
4040

4141
private readonly toDispose = new DisposableCollection();
4242
private readonly onDaemonStartedEmitter = new Emitter<string>();
@@ -89,14 +89,8 @@ export class ArduinoDaemonImpl
8989

9090
this.toDispose.pushAll([
9191
Disposable.create(() => {
92-
if (daemon.pid) {
93-
this.processUtils.terminateProcessTree(daemon.pid);
94-
this.fireDaemonStopped();
95-
} else {
96-
throw new Error(
97-
'The CLI Daemon process does not have a PID. IDE2 could not stop the CLI daemon.'
98-
);
99-
}
92+
daemon.kill();
93+
this.fireDaemonStopped();
10094
}),
10195
]);
10296
this.fireDaemonStarted(port);

0 commit comments

Comments
 (0)