pass -v and --log-level to plugin
#175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
type: enhancement
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## plugins #175 +/- ##
==========================================
- Coverage 6.72% 6.66% -0.06%
==========================================
Files 24 24
Lines 2126 2144 +18
==========================================
Hits 143 143
- Misses 1925 1943 +18
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cmaglie
approved these changes
Jul 13, 2023
cmaglie
added a commit
that referenced
this pull request
Jul 14, 2023
* Removed useless 'required' tag * Added fields for plugin system * Made LatestFirmware a method of BoardIndex * Fixed some linter warnings * Tools required for plugins are now downloaded * Created infrastructure for plugin based get-version Equivalent code changes, no changes in behaviour * Added FwPlugin object to ease access to fwuploader-plugins * get-version now supports fwuploader-plugins * Added license cache * Better recording of errors from plugins * Extracted function to exec fwuploader plugins * Small cosmetic changes - perform arg checks early - removed unneeded err variable in function scope * Another cosmetic change * Prepared scaffolding for flash-firmware command using plugins * Implemented plugin-based firmware upload * Using packagemanager to handle package_index downloads * Added additional index URLx flags to ease plugin development * Added missing license data * Allow file paths as additional 'urls' * Verify signarure only on offical indexes * Improve error messages and avoid panic in case of missing tool * Avoid double buffering of command output in getFirmwareVersion * Allow merging with overwrite This means that additional indexex are allowed to overwrite official boards. * Added plugin-based firmware index * add support for arduino/fwuploader-plugin-helper#9 (#174) * Created scaffolding to implement certificate upload via plugin * Removed useless variable * Avoid globals arguemnts in flash-certificate * Factored function to scrape TLS certs from webserver * Factored function to read certificates * Small refactoring in cert building subroutines * Factored function to encode certs as PEM * Added certificate flash support for plugins * fix licensed * Make board override less strict * Do not consider LICENSE files in plugins archive * Fixed PEM decoding... 🤦 * pass `-v` and `--log-level` to plugin (#175) * move vars to global * add support for arduino/fwuploader-plugin-helper#10 * Update cli/common/common.go Co-authored-by: Umberto Baldi <[email protected]> * Renamed variable for clarity --------- Co-authored-by: Umberto Baldi <[email protected]> Co-authored-by: Umberto Baldi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for arduino/fwuploader-plugin-helper#10