Skip to content

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Dec 5, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

bump dependencies

  • What is the current behavior?

The dependencies are outdated

  • What is the new behavior?

the dependencies are updated

  • Does this PR introduce a breaking change?

no

  • Other information:

@umbynos umbynos added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure labels Dec 5, 2022
@umbynos umbynos self-assigned this Dec 5, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 11.08% // Head: 11.05% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (9aef2ae) compared to base (64742a0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
- Coverage   11.08%   11.05%   -0.03%     
==========================================
  Files          50       50              
  Lines        3853     3853              
==========================================
- Hits          427      426       -1     
- Misses       3372     3373       +1     
  Partials       54       54              
Flag Coverage Δ
unit 11.05% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 2.58% <0.00%> (ø)
systray/systray.go 0.00% <0.00%> (ø)
systray/systray_real.go 0.00% <0.00%> (ø)
update.go 0.00% <0.00%> (ø)
updater/updater.go 0.00% <0.00%> (ø)
v2/pkgs/indexes.go 61.29% <ø> (ø)
upload/upload.go 41.15% <0.00%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@umbynos
Copy link
Contributor Author

umbynos commented Dec 5, 2022

I did not bumped:

Every other dependency has been updated to the latest version available.

Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Mac OS 12.6

LGTM

@umbynos
Copy link
Contributor Author

umbynos commented Dec 5, 2022

Tested on linux and win

@umbynos umbynos merged commit 4ceaa5a into main Dec 5, 2022
@umbynos umbynos deleted the bump-deps branch December 5, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants