Skip to content

Support compilation extrafiles on ChromeOS #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csarnataro merged 3 commits into from
Dec 13, 2021
Merged

Support compilation extrafiles on ChromeOS #541

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34420ed
Adding support for RP2040.
csarnataro Nov 29, 2021
bffbc2b
Support compilation extrafiles on ChromeOS
csarnataro Dec 9, 2021
7315a39
Fixed wrong check on 'uploadCommandInfo.files'
csarnataro Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "arduino-create-agent-js-client",
"version": "2.6.0",
"version": "2.7.0",
"description": "JS module providing discovery of the Arduino Create Plugin and communication with it",
"main": "lib/index.js",
"module": "es/index.js",
Expand Down
9 changes: 5 additions & 4 deletions src/chrome-app-daemon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,9 @@ export default class ChromeOsDaemon extends Daemon {
* data: "compiled sketch"
* }
*/
_upload({
board, port, commandline, data
}) {
_upload(uploadPayload, uploadCommandInfo) {
const { board, port, commandline, data } = uploadPayload;
const extrafiles = uploadCommandInfo && uploadCommandInfo.files && Array.isArray(uploadCommandInfo.files) || []
Copy link
Collaborator Author

@csarnataro csarnataro Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not working as expected, I'm going to push a fix in a few minutes.

try {
window.oauth.token().then(token => {
this.channel.postMessage({
Expand All @@ -249,7 +249,8 @@ export default class ChromeOsDaemon extends Daemon {
port,
commandline,
data,
token: token.token
token: token.token,
extrafiles
}
});
});
Expand Down