Skip to content

Move default include files where protoc can find them #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2019
Merged

Move default include files where protoc can find them #288

merged 1 commit into from
Jul 17, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Jul 17, 2019

protoc will search for include files in the same folder of the binary by default. This will allow us to avoid specifying -I explicitly, leaving to the host running the compiler to put things in the right place.

rsora
rsora approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masci masci merged commit 54095c9 into master Jul 17, 2019
@masci masci deleted the massi/ci branch July 17, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rsora rsora rsora approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masci @rsora