Refactored build-properties creation (and removed some legacy code)

[cmaglie]

Please check if the PR fulfills these requirements

See how to contribute

• The PR has no duplicates (please search among the Pull Requests
  before creating one)
• The PR follows
  our contributing guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

It moves most of the build-properties creation out of the legacy package. This has some advantages:

• It has centralized the place where these build properties are made, so we removed some duplicated logic
• This is particularly true for the runtime.tools.* properties generation
• It fixes Uploader prefs miss {build.core.path}, {build.system.path} and {build.variant.path} #1012: some of the build.* properties are now available on upload actions

What is the current behavior?

Build properties are missing for upload recipes.

What is the new behavior?

Build properties are now available in upload recipes.

Does this PR introduce a breaking change, and is titled accordingly?

No breaking changes.

Other information

[codecov]

Codecov Report

Base: 36.54% // Head: 36.65% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (6ad5342) compared to base (c660b33).
Patch coverage: 82.56% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2082      +/-   ##
==========================================
+ Coverage   36.54%   36.65%   +0.10%     
==========================================
  Files         229      229              
  Lines       19538    19538              
==========================================
+ Hits         7141     7162      +21     
+ Misses      11557    11541      -16     
+ Partials      840      835       -5     

Flag	Coverage Δ
unit	36.65% <82.56%> (+0.10%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
commands/compile/compile.go	0.00% <ø> (ø)
commands/upload/upload.go	55.81% <ø> (+1.08%)	⬆️
legacy/builder/builder.go	84.84% <ø> (ø)
legacy/builder/setup_build_properties.go	68.75% <0.00%> (-17.12%)	⬇️
legacy/builder/types/context.go	73.13% <ø> (-0.40%)	⬇️
legacy/builder/target_board_resolver.go	70.96% <40.00%> (-2.57%)	⬇️
arduino/cores/packagemanager/package_manager.go	71.07% <84.84%> (+2.88%)	⬆️
arduino/cores/board.go	92.06% <100.00%> (+0.12%)	⬆️
arduino/cores/cores.go	62.37% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Bikappa]

lgtm