[skip-changelog] Do not force update index every time lib search is executed
#2072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
MatteoPologruto
force-pushed
the
cli/cached-lib-search
branch
from
f8679ad to
6c89894
Compare
Codecov ReportBase: 36.68% // Head: 36.65% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2072 +/- ##
==========================================
- Coverage 36.68% 36.65% -0.03%
==========================================
Files 228 228
Lines 19385 19400 +15
==========================================
Hits 7111 7111
- Misses 11442 11457 +15
Partials 832 832
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cmaglie
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Code enhancement
What is the current behavior?
Executing
lib searchalways downloads and updateslibrary_index.json.What is the new behavior?
A timeout has been introduced to avoid updating the index every time
lib searchis executed.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
This is a duplicate of #1789. Since the original author did not make any recent update, I'm simply rebasing his commits and applying the suggestions. Once this PR is merged, the original can be closed.
Close #1789