[breaking] uniform cli commands and flag #1542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
type: enhancement
umbynos
force-pushed
the
umbynos/flags_refactoring
branch
from
ba5385f to
66dbc61
Compare
per1234
requested changes
Nov 10, 2021
There was a problem hiding this comment.
Since this is a big PR that contains multiple atomic commits, I recommend it be granted an exemption from the repo's usual squash merge policy.
This would be done by temporarily adjusting the configuration of the repo's merge button, following this procedure:
- Click the "⚙️ Settings" tab of the repository that contains the PR
- Under the "Merge button" section of the Settings page, check the box next to "🔲 Allow merge commits"
- Merge the PR, selecting the "Merge pull request" option from the merge button
- Return to the repository's Settings page
- Uncheck the box next to "🔲 Allow merge commits"
Since the commits will not be automatically squashed, any fixup commits should be manually squashed via an interactive rebase before the merge.
umbynos
force-pushed
the
umbynos/flags_refactoring
branch
4 times, most recently
from
2edafc0 to
80be710
Compare
umbynos
changed the title
umbynos
force-pushed
the
umbynos/flags_refactoring
branch
from
4d2df31 to
8713d91
Compare
per1234
requested changes
Nov 11, 2021
per1234
approved these changes
Nov 11, 2021
umbynos
force-pushed
the
umbynos/flags_refactoring
branch
2 times, most recently
from
fb73cf8 to
61dba74
Compare
umbynos
force-pushed
the
umbynos/flags_refactoring
branch
from
61dba74 to
e092b26
Compare
move `DetectSkipPostInstallValue` in arguments package create `PostInstallFlags` struct in arguments package remove `listFlags` struct
…rd attach -b <fqbn> | -p <port> <sketh-path>`
umbynos
force-pushed
the
umbynos/flags_refactoring
branch
from
e092b26 to
294c7bc
Compare
silvanocerza
approved these changes
Nov 19, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)refactor CLI commands and flags to be consistent with each other.
close #1508
This PR includes various improvements:
sketchpath calculation have been factored out
fqbn and programmer flags now have the same principle of operation as port flag
factored out a function that reports errors when conflicting flags are used
move vars on top and remove structs for uniformity
part of the init section in
update-indexcommands have been factored outother minor improvements
I also added
logrus.Info()in every run function of every commandremove
board details <fqbn>in favour ofboard details -b <fqbn>replace
board attach <port|fqbn> <sketch-path>withboard attach -b <fqbn> | -p <port> <sketh-path>change
--timeoutflag to--discovery-timeoutinboard listcommand for consistencyDoes this PR introduce a breaking change, and is
titled accordingly?
yep, documented in
UPGRADING.mdSee how to contribute