Skip to content

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Oct 12, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Enhances an existing error message.

  • What is the current behavior?

Calling a command that expects an FQBN with one that contains a board ID that doesn't exist returns this error message:

Error resolving FQBN: board arduino:[email protected]:mkr1010 not found
  • What is the new behavior?

Calling a command that expects an FQBN with one that contains a board ID that doesn't exist now returns this error message:

Error resolving FQBN: board arduino:samd:mkr1010 not found

Nope.

  • Other information:

None.


See how to contribute

@silvanocerza silvanocerza added the type: enhancement Proposed improvement label Oct 12, 2021
@silvanocerza silvanocerza requested a review from a team October 12, 2021 13:16
@silvanocerza silvanocerza self-assigned this Oct 12, 2021
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally 📦

@silvanocerza silvanocerza force-pushed the scerza/enhance-error-message branch 3 times, most recently from 0fbcd73 to c2fb369 Compare October 15, 2021 12:37
@silvanocerza silvanocerza force-pushed the scerza/enhance-error-message branch from c2fb369 to f2ef066 Compare October 18, 2021 14:08
@silvanocerza silvanocerza merged commit 126bb02 into master Oct 18, 2021
@silvanocerza silvanocerza deleted the scerza/enhance-error-message branch October 18, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants