Skip to content

Improve hex merger #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Improve hex merger #295

wants to merge 5 commits into from

Conversation

facchinm
Copy link
Member

@facchinm facchinm commented Sep 20, 2018 •
edited
Loading

Fixes #286

WARNING: still doesn't work with Caterina based bootloaders (because of sections overlapping)

@facchinm
Start introducing a proper hex merger
1707aec 
Uses github.com/marcinbor85/gohex as additiona dependency
@facchinm
Properly handle hex<->bin operations
7a6bad6
@facchinm
Fix merge bootloader test
9a61ec1 
Since we have a proper hex merger now, let's fix the dummy tests
We should also add some new tests (for overlapping sections, for example)
@facchinm
Travis: add dependency from gohex
d6536f4
@facchinm facchinm added this to the next milestone Sep 20, 2018
@facchinm facchinm mentioned this pull request Sep 20, 2018
Closed
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-295.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@facchinm facchinm mentioned this pull request Nov 23, 2018
Closed
facchinm
facchinm commented Mar 6, 2019
View reviewed changes
merge_sketch_with_bootloader.go

return utils.WriteFile(mergedSketchPath, strings.Join(sketch, "\n"))
bytes := mem_merge.ToBinary(initial_address, last_address-initial_address, 0xFF)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must only be executed if address space is continuous (otherwise we can get a huge file as result)

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-295.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@cmaglie cmaglie mentioned this pull request Jun 8, 2020
Merged
@facchinm
Copy link
Member Author

facchinm commented Jun 8, 2020

Replaced by arduino/arduino-cli#744

@facchinm facchinm closed this Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

with_bootloader issues
2 participants
@facchinm @ArduinoBot