Do not full-rebuild if only sketch path changed. #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ath changed. This commit fix two problems: 1) the sketch path is used as-is in a regexp: this causes troubles if the path contains regexp control chars like `[-]().\` etc. 2) the sketch is not fully rebuild if the only thing that changes is the sketch path. Signed-off-by: Cristian Maglie <[email protected]>
|
Wonderful |
…esting Signed-off-by: Cristian Maglie <[email protected]>
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix two problems:
[-]().\etc.this PR supersedes #135