-
-
Notifications
You must be signed in to change notification settings - Fork 114
Closed
Labels
conclusion: resolvedIssue was resolvedIssue was resolvedtopic: codeRelated to content of the project itselfRelated to content of the project itselftype: imperfectionPerceived defect in any part of projectPerceived defect in any part of project
Description
This is a sketch with only CR as end-of-line markers (\r instead of \r\n)
The builder crashes with
panic: runtime error: slice bounds out of range
goroutine 1 [running]:
arduino.cc/builder.(*PrototypesAdder).Run(0x732dd8, 0xc820012690, 0x0, 0x0)
/home/msuppo/Work/arduino/arduino-builder/src/github.com/arduino/arduino-builder/src/arduino.cc/builder/prototypes_adder.go:78 +0x17da
arduino.cc/builder.(*ContainerAddPrototypes).Run(0x732dd8, 0xc820012690, 0x0, 0x0)
/home/msuppo/Work/arduino/arduino-builder/src/github.com/arduino/arduino-builder/src/arduino.cc/builder/container_add_prototypes.go:56 +0x4f2
arduino.cc/builder.runCommands(0xc820012690, 0xc820311aa0, 0x1d, 0x1d, 0x1, 0x0, 0x0)
/home/msuppo/Work/arduino/arduino-builder/src/github.com/arduino/arduino-builder/src/arduino.cc/builder/builder.go:187 +0x12b
arduino.cc/builder.(*Builder).Run(0xc820311c98, 0xc820012690, 0x0, 0x0)
/home/msuppo/Work/arduino/arduino-builder/src/github.com/arduino/arduino-builder/src/arduino.cc/builder/builder.go:118 +0xe53
arduino.cc/builder.RunBuilder(0xc820012690, 0x0, 0x0)
/home/msuppo/Work/arduino/arduino-builder/src/github.com/arduino/arduino-builder/src/arduino.cc/builder/builder.go:218 +0x39
main.main()
/home/msuppo/Work/arduino/arduino-builder/src/github.com/arduino/arduino-builder/main.go:320 +0x2183
I debugged and discovered that the source code is not correctly divided into lines because of the CR, so it tries to split the source after it had ended, somehow :S
Metadata
Metadata
Assignees
Labels
conclusion: resolvedIssue was resolvedIssue was resolvedtopic: codeRelated to content of the project itselfRelated to content of the project itselftype: imperfectionPerceived defect in any part of projectPerceived defect in any part of project