This repository was archived by the owner on Apr 1, 2022. It is now read-only.
libraries/compile-examples: install dependencies from local path using symlinks #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g symlinks Previously, the shared function used to install dependencies from local paths used copy instead of symlinks. The switch to using copy for everything was done for a couple of reasons: - Some functions were already using copy/move to install because they worked from temporary folders that are deleted by the context manager - Use of symlinks on Windows requires the script to be run as administrator, which makes it less friendly to contributors or users running the script locally who are using Windows However, the previous symlinks were essential for the deltas feature to work for libraries or platforms under test because these are installed to a different location than the repository that is checked out to the delta and head refs. When the project under test is a sketch, symlinks are not necessary, since the sketch is run in place, which is why this bug was not detected via minimal informal integration tests. The first reason to copy listed above is easily overcome by changing the code to create temporary folders with the required lifespan. The second remains, but it's easy enough to find the solution to the error message resulting from running the script without the necessary permissions.
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 2 2
Lines 626 1545 +919
==========================================
+ Hits 626 1545 +919
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the shared function used to install dependencies from local paths used copy instead of symlinks.
The switch to using copy for everything was done for a couple of reasons:
However, the previous symlinks were essential for the deltas feature to work for libraries or platforms under test because these are installed to a different location than the repository that is checked out to the delta base and head refs.
When the project under test is a sketch, symlinks are not necessary, since the sketch is run in place, which is why this bug was not detected via minimal the informal integration testing done on the change.