Skip to content

Set full PINCFG register on pinMode(pin, OUTPUT) #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2017
Merged

Set full PINCFG register on pinMode(pin, OUTPUT) #207

merged 1 commit into from
Jan 27, 2017

Conversation

sandeepmistry
Copy link
Contributor

This change is a proposal to fix #205.

cc/ @kiptonk

@sandeepmistry sandeepmistry mentioned this pull request Jan 24, 2017
Closed
@ArduinoBot
Copy link

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/samd/package_samd-b138_index.json

ℹ️ To test this build:

  1. Open the Preferences of the Arduino IDE.
  2. Add the Build URL above in the Additional Boards Manager URLs field, and click OK.
  3. Open the Boards Manager (menu Tools->Board->Board Manager...)
  4. Install Arduino SAMD core - Pull Request Set full PINCFG register on pinMode(pin, OUTPUT) #207
  5. Select one of the boards under SAMD Pull Request Set full PINCFG register on pinMode(pin, OUTPUT) #207 in Tools->Board menu
  6. Compile/Upload as usual

@kiptonk
Copy link

kiptonk commented Jan 25, 2017

This looks good, thanks!

@agdl agdl merged commit 6fe8574 into arduino:master Jan 27, 2017
@sandeepmistry sandeepmistry added this to the Release 1.6.12 milestone Jan 27, 2017
@sandeepmistry sandeepmistry deleted the analog-digital-output-fix branch January 27, 2017 13:30
@sandeepmistry
Copy link
Contributor Author

@kiptonk great, thank you for testing! The change will be part of the next SAMD core release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm facchinm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.6.12
Development

Successfully merging this pull request may close these issues.

analogRead() followed by pinMode(,OUTPUT) leaves pin muxed to ADC
6 participants
@sandeepmistry @ArduinoBot @kiptonk @sellensr @facchinm @agdl