Skip to content

Avoid shadowing Stream.setTimeout #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Avoid shadowing Stream.setTimeout #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28d74d7
SSLClient: rename setTimeout in setConnectionTimeout
pennam Sep 18, 2023
0cd9344
lwipClient: rename setTimeout in setConnectionTimeout
pennam Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/SSLClient/src/SSLClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ void SSLClient::setHandshakeTimeout(unsigned long handshake_timeout)
sslclient->handshake_timeout = handshake_timeout * 1000;
}

void SSLClient::setTimeout(unsigned long seconds)
void SSLClient::setConnectionTimeout(unsigned long seconds)
{
_timeout = seconds * 1000;
}
2 changes: 1 addition & 1 deletion libraries/SSLClient/src/SSLClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class SSLClient : public Client
bool verify(const char* fingerprint, const char* domain_name);
void setHandshakeTimeout(unsigned long handshake_timeout);

void setTimeout(unsigned long seconds);
void setConnectionTimeout(unsigned long seconds);

operator bool()
{
Expand Down
2 changes: 1 addition & 1 deletion libraries/lwIpWrapper/src/lwipClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class lwipClient : public Client {
{
return (_tcp_client->pcb->remote_port);
};
void setTimeout(uint16_t timeout)
void setConnectionTimeout(uint16_t timeout)
{
_timeout = timeout;
}
Expand Down