Fix F macro definition #82
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think this PR does not solve the problems illustrated at #62 (comment) and subsequent comments. I haven't got time to re-read those comments and comment on a proper approach, but I think this PR is unfortunately not enough to make this work... |
giulcioffi
force-pushed
the
issue62_FMacro
branch
from
7dde89d to
737660e
Compare
|
Memory usage change @ 737660e
Click for full report table
Click for full report CSV |
|
Memory usage change @ 666a6f6
Click for full report table
Click for full report CSV |
|
This fixed my build issue. It may not be the best fix, as @matthijskooijman suggests, but at least I'm unblocked now and can continue with my project. Thanks. |
Contributor
|
Question @giulcioffi : Should |
Contributor
Author
|
@aentinger ArduinoCore-API provides an implementation of |
Member
|
I'm still unsure there's a perfect way to tackle this. |
Collaborator
|
I think that the goal of this PR, to make However, I don't like the approach taken by this PR, namely to duplicate a file that's also shipped with avr-libc. I also wonder if it is even needed, since the So I would that simply removing the redefinition of
@facchinm, what failure are you referring to exactly? I think the problem here is simply that the API exposed by the combination of |
facchinm
force-pushed
the
issue62_FMacro
branch
from
666a6f6 to
04105f5
Compare
Contributor
|
Closing, for details see #62 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to solve isse #62. The F() macro has been implemented as in typical AVR architecture: in
String.hclass __FlashStringHelper;#define F(string_literal) (reinterpret_cast<const __FlashStringHelper *>(PSTR(string_literal)))pgmspace.his not included anymore from ArduinoCore-API/api/deprecated-avr-comp, but is the one provided by avr-libc. It has been copied from there and inserted into a new foldertools. This has been done to avoid modifications inside ArduinoCore-API.