Skip to content

Conversation

@JAndrassy
Copy link
Contributor

the include for the include of QSPIFBlockDevice.h for constant QSPIF_BD_ERROR_OK with value 0 is unnecessary and creates an unnecessary compile dependency.

The doc for BlockDevice::init has

    /** Initialize a block device
     *
     *  @return         0 on success or a negative error code on failure
     */

so it is OK to compare the return value to 0.

@facchinm facchinm merged commit 3142985 into arduino:main Nov 13, 2023
@JAndrassy JAndrassy deleted the sslclient_cut_dep branch November 13, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants