Skip to content

Offline unit tests for GzippedJsonDownloaderTest and JsonDownloaderTest #9699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Offline unit tests for GzippedJsonDownloaderTest and JsonDownloaderTest #9699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/test/cc/arduino/contributions/GzippedJsonDownloaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,13 @@ public void tearDown() throws Exception {

@Test
public void testJsonDownload() throws Exception {
new GZippedJsonDownloader(downloader, new URL("http://downloads.arduino.cc/libraries/library_index.json"),
new URL("http://downloads.arduino.cc/libraries/library_index.json.gz"))
// URL url = new URL("http://downloads.arduino.cc/libraries/library_index.json")
// URL gzUrl = new URL("http://downloads.arduino.cc/libraries/library_index.json.gz")

URL url = GZippedJsonDownloader.class.getResource("/library_index.json");
URL gzUrl = GZippedJsonDownloader.class.getResource("/library_index.json.gz");

new GZippedJsonDownloader(downloader, url, gzUrl)
.download(tempFile, new MultiStepProgress(1), "", new NoopProgressListener(), true);

InputStream indexIn = new FileInputStream(tempFile);
Expand Down
6 changes: 5 additions & 1 deletion app/test/cc/arduino/contributions/JsonDownloaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@ public void tearDown() throws Exception {

@Test
public void testJsonDownload() throws Exception {
new JsonDownloader(downloader, new URL("http://downloads.arduino.cc/libraries/library_index.json"))
// URL url = new URL("http://downloads.arduino.cc/libraries/library_index.json")

URL url = JsonDownloader.class.getResource("/library_index.json");

new JsonDownloader(downloader, url)
.download(tempFile, new MultiStepProgress(1), "", new NoopProgressListener(), true);

InputStream indexIn = new FileInputStream(tempFile);
Expand Down
Loading