Skip to content

Use wifi fw version cbor encoder of CloudUtils #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

Use wifi fw version cbor encoder of CloudUtils #14

merged 1 commit into from
Jul 3, 2025

Conversation

fabik111
Copy link
Collaborator

@fabik111 fabik111 commented Jun 4, 2025

Changes:

  • use WiFi FW version cbor encoder from CloudUtils
  • remove the internal definition

This PR relies on arduino-libraries/Arduino_CloudUtils#33

@fabik111 fabik111 requested a review from pennam June 4, 2025 15:27
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 4, 2025
@fabik111 fabik111 force-pushed the move-wifi-version-encoder branch from 6ccc823 to dca92d2 Compare June 4, 2025 15:36
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (7bf56c8) to head (b5a3fc7).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   90.04%   90.15%   +0.11%     
==========================================
  Files           7        7              
  Lines         713      691      -22     
  Branches       86       83       -3     
==========================================
- Hits          642      623      -19     
+ Misses         71       68       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025

Memory usage change @ dca92d2

Board flash % RAM for global variables %
arduino:mbed_giga:giga 💚 -152 - -152 -0.01 - -0.01 💚 -32 - -32 -0.01 - -0.01
arduino:mbed_nano:nanorp2040connect 💚 -150 - -150 -0.0 - -0.0 💚 -24 - -24 -0.01 - -0.01
arduino:mbed_nicla:nicla_vision 💚 -152 - -152 -0.01 - -0.01 💚 -32 - -32 -0.01 - -0.01
arduino:mbed_opta:opta 💚 -88 - -88 -0.0 - -0.0 💚 -32 - -32 -0.01 - -0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 💚 -128 - -128 -0.01 - -0.01 💚 -32 - -32 -0.01 - -0.01
arduino:renesas_uno:unor4wifi 💚 -136 - -136 -0.05 - -0.05 💚 -24 - -24 -0.07 - -0.07
arduino:samd:mkrwifi1010 💚 -144 - -144 -0.05 - -0.05 💚 -24 - -24 -0.07 - -0.07
arduino:samd:nano_33_iot 💚 -144 - -144 -0.05 - -0.05 💚 -24 - -24 -0.07 - -0.07
Click for full report table
Board examples/NetworkConfiguratorDemo
flash		 % examples/NetworkConfiguratorDemo
RAM for global variables		 %
arduino:mbed_giga:giga -152 -0.01 -32 -0.01
arduino:mbed_nano:nanorp2040connect -150 -0.0 -24 -0.01
arduino:mbed_nicla:nicla_vision -152 -0.01 -32 -0.01
arduino:mbed_opta:opta -88 -0.0 -32 -0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 -128 -0.01 -32 -0.01
arduino:renesas_uno:unor4wifi -136 -0.05 -24 -0.07
arduino:samd:mkrwifi1010 -144 -0.05 -24 -0.07
arduino:samd:nano_33_iot -144 -0.05 -24 -0.07
Click for full report CSV 
Board,examples/NetworkConfiguratorDemo<br>flash,%,examples/NetworkConfiguratorDemo<br>RAM for global variables,%
arduino:mbed_giga:giga,-152,-0.01,-32,-0.01
arduino:mbed_nano:nanorp2040connect,-150,-0.0,-24,-0.01
arduino:mbed_nicla:nicla_vision,-152,-0.01,-32,-0.01
arduino:mbed_opta:opta,-88,-0.0,-32,-0.01
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,-128,-0.01,-32,-0.01
arduino:renesas_uno:unor4wifi,-136,-0.05,-24,-0.07
arduino:samd:mkrwifi1010,-144,-0.05,-24,-0.07
arduino:samd:nano_33_iot,-144,-0.05,-24,-0.07

@fabik111 fabik111 force-pushed the move-wifi-version-encoder branch from dca92d2 to b764167 Compare June 19, 2025 10:18
@github-actions GitHub Actions
Copy link

Memory usage change @ b764167

Board flash % RAM for global variables %
arduino:mbed_giga:giga 💚 -152 - -152 -0.01 - -0.01 💚 -32 - -32 -0.01 - -0.01
arduino:mbed_nano:nanorp2040connect 💚 -150 - -150 -0.0 - -0.0 💚 -24 - -24 -0.01 - -0.01
arduino:mbed_nicla:nicla_vision 💚 -152 - -152 -0.01 - -0.01 💚 -32 - -32 -0.01 - -0.01
arduino:mbed_opta:opta 💚 -88 - -88 -0.0 - -0.0 💚 -32 - -32 -0.01 - -0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 💚 -128 - -128 -0.01 - -0.01 💚 -32 - -32 -0.01 - -0.01
arduino:renesas_uno:unor4wifi 💚 -136 - -136 -0.05 - -0.05 💚 -24 - -24 -0.07 - -0.07
arduino:samd:mkrwifi1010 💚 -144 - -144 -0.05 - -0.05 💚 -24 - -24 -0.07 - -0.07
arduino:samd:nano_33_iot 💚 -144 - -144 -0.05 - -0.05 💚 -24 - -24 -0.07 - -0.07
Click for full report table
Board examples/NetworkConfiguratorDemo
flash		 % examples/NetworkConfiguratorDemo
RAM for global variables		 %
arduino:mbed_giga:giga -152 -0.01 -32 -0.01
arduino:mbed_nano:nanorp2040connect -150 -0.0 -24 -0.01
arduino:mbed_nicla:nicla_vision -152 -0.01 -32 -0.01
arduino:mbed_opta:opta -88 -0.0 -32 -0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 -128 -0.01 -32 -0.01
arduino:renesas_uno:unor4wifi -136 -0.05 -24 -0.07
arduino:samd:mkrwifi1010 -144 -0.05 -24 -0.07
arduino:samd:nano_33_iot -144 -0.05 -24 -0.07
Click for full report CSV 
Board,examples/NetworkConfiguratorDemo<br>flash,%,examples/NetworkConfiguratorDemo<br>RAM for global variables,%
arduino:mbed_giga:giga,-152,-0.01,-32,-0.01
arduino:mbed_nano:nanorp2040connect,-150,-0.0,-24,-0.01
arduino:mbed_nicla:nicla_vision,-152,-0.01,-32,-0.01
arduino:mbed_opta:opta,-88,-0.0,-32,-0.01
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,-128,-0.01,-32,-0.01
arduino:renesas_uno:unor4wifi,-136,-0.05,-24,-0.07
arduino:samd:mkrwifi1010,-144,-0.05,-24,-0.07
arduino:samd:nano_33_iot,-144,-0.05,-24,-0.07

@fabik111 fabik111 force-pushed the move-wifi-version-encoder branch from b764167 to e58ff44 Compare June 25, 2025 12:19
@github-actions GitHub Actions
Copy link

Memory usage change @ e58ff44

Board flash % RAM for global variables %
arduino:mbed_giga:giga 💚 -152 - -152 -0.01 - -0.01 💚 -32 - -32 -0.01 - -0.01
arduino:mbed_nano:nanorp2040connect 💚 -150 - -150 -0.0 - -0.0 💚 -24 - -24 -0.01 - -0.01
arduino:mbed_nicla:nicla_vision 💚 -152 - -152 -0.01 - -0.01 💚 -32 - -32 -0.01 - -0.01
arduino:mbed_opta:opta 💚 -88 - -88 -0.0 - -0.0 💚 -32 - -32 -0.01 - -0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 💚 -128 - -128 -0.01 - -0.01 💚 -32 - -32 -0.01 - -0.01
arduino:renesas_uno:unor4wifi 💚 -136 - -136 -0.05 - -0.05 💚 -24 - -24 -0.07 - -0.07
arduino:samd:mkrwifi1010 💚 -144 - -144 -0.05 - -0.05 💚 -24 - -24 -0.07 - -0.07
arduino:samd:nano_33_iot 💚 -144 - -144 -0.05 - -0.05 💚 -24 - -24 -0.07 - -0.07
Click for full report table
Board examples/NetworkConfiguratorDemo
flash		 % examples/NetworkConfiguratorDemo
RAM for global variables		 %
arduino:mbed_giga:giga -152 -0.01 -32 -0.01
arduino:mbed_nano:nanorp2040connect -150 -0.0 -24 -0.01
arduino:mbed_nicla:nicla_vision -152 -0.01 -32 -0.01
arduino:mbed_opta:opta -88 -0.0 -32 -0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 -128 -0.01 -32 -0.01
arduino:renesas_uno:unor4wifi -136 -0.05 -24 -0.07
arduino:samd:mkrwifi1010 -144 -0.05 -24 -0.07
arduino:samd:nano_33_iot -144 -0.05 -24 -0.07
Click for full report CSV 
Board,examples/NetworkConfiguratorDemo<br>flash,%,examples/NetworkConfiguratorDemo<br>RAM for global variables,%
arduino:mbed_giga:giga,-152,-0.01,-32,-0.01
arduino:mbed_nano:nanorp2040connect,-150,-0.0,-24,-0.01
arduino:mbed_nicla:nicla_vision,-152,-0.01,-32,-0.01
arduino:mbed_opta:opta,-88,-0.0,-32,-0.01
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,-128,-0.01,-32,-0.01
arduino:renesas_uno:unor4wifi,-136,-0.05,-24,-0.07
arduino:samd:mkrwifi1010,-144,-0.05,-24,-0.07
arduino:samd:nano_33_iot,-144,-0.05,-24,-0.07

@fabik111 fabik111 force-pushed the move-wifi-version-encoder branch from e58ff44 to b5a3fc7 Compare July 2, 2025 12:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2025

Memory usage change @ b5a3fc7

Board flash % RAM for global variables %
arduino:mbed_giga:giga 💚 -144 - -144 -0.01 - -0.01 💚 -32 - -32 -0.01 - -0.01
arduino:mbed_nano:nanorp2040connect 💚 -146 - -146 -0.0 - -0.0 💚 -24 - -24 -0.01 - -0.01
arduino:mbed_nicla:nicla_vision 💚 -144 - -144 -0.01 - -0.01 💚 -32 - -32 -0.01 - -0.01
arduino:mbed_opta:opta 💚 -152 - -152 -0.01 - -0.01 💚 -32 - -32 -0.01 - -0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 💚 -112 - -112 -0.01 - -0.01 💚 -32 - -32 -0.01 - -0.01
arduino:renesas_uno:unor4wifi 💚 -112 - -112 -0.04 - -0.04 💚 -24 - -24 -0.07 - -0.07
arduino:samd:mkrwifi1010 💚 -136 - -136 -0.05 - -0.05 💚 -24 - -24 -0.07 - -0.07
arduino:samd:nano_33_iot 💚 -144 - -144 -0.05 - -0.05 💚 -24 - -24 -0.07 - -0.07
Click for full report table
Board examples/NetworkConfiguratorDemo
flash		 % examples/NetworkConfiguratorDemo
RAM for global variables		 %
arduino:mbed_giga:giga -144 -0.01 -32 -0.01
arduino:mbed_nano:nanorp2040connect -146 -0.0 -24 -0.01
arduino:mbed_nicla:nicla_vision -144 -0.01 -32 -0.01
arduino:mbed_opta:opta -152 -0.01 -32 -0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 -112 -0.01 -32 -0.01
arduino:renesas_uno:unor4wifi -112 -0.04 -24 -0.07
arduino:samd:mkrwifi1010 -136 -0.05 -24 -0.07
arduino:samd:nano_33_iot -144 -0.05 -24 -0.07
Click for full report CSV 
Board,examples/NetworkConfiguratorDemo<br>flash,%,examples/NetworkConfiguratorDemo<br>RAM for global variables,%
arduino:mbed_giga:giga,-144,-0.01,-32,-0.01
arduino:mbed_nano:nanorp2040connect,-146,-0.0,-24,-0.01
arduino:mbed_nicla:nicla_vision,-144,-0.01,-32,-0.01
arduino:mbed_opta:opta,-152,-0.01,-32,-0.01
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,-112,-0.01,-32,-0.01
arduino:renesas_uno:unor4wifi,-112,-0.04,-24,-0.07
arduino:samd:mkrwifi1010,-136,-0.05,-24,-0.07
arduino:samd:nano_33_iot,-144,-0.05,-24,-0.07

@fabik111 fabik111 requested a review from andreagilardoni July 3, 2025 09:08
@fabik111 fabik111 merged commit 4bcfe6a into main Jul 3, 2025
28 checks passed
@fabik111 fabik111 deleted the move-wifi-version-encoder branch July 3, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreagilardoni andreagilardoni andreagilardoni approved these changes

@pennam pennam Awaiting requested review from pennam

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabik111 @andreagilardoni @per1234