-
Notifications
You must be signed in to change notification settings - Fork 4
Preliminary Giga Touch support on Zephyr #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@per1234 @leonardocavagnis and all... Not sure what to do with this clang format failure? Looks like you added this something like two years ago, and Not sure that is something that should be done as part of this PR? As for example, I have not touched any of your Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this yet but I think we should move this to a separate file? For example src/Arduino_GigaDisplayTouchZephyr.cpp
and then move the old one to src/Arduino_GigaDisplayTouchMbed.cpp
Also, please fix your formatting. For example:
- Please pick a style:
Arduino_GigaDisplayTouch::~Arduino_GigaDisplayTouch()
{
}
bool Arduino_GigaDisplayTouch::begin() {
- Fix indentation:
void Arduino_GigaDisplayTouch::end()
{
registerGigaTouchCallback(nullptr);
}
- Remove empty lines such as:
uint8_t Arduino_GigaDisplayTouch::getTouchPoints(GDTpoint_t* points, uint32_t timeout) {
// First wait to see if we get any events.
- Remove empty spaces at end of lines:
// First wait to see if we get any events.
c25db92
to
9ca5d22
Compare
@iabdalkader - I did a combination, where I tried to merge the two sections of the header file into one. Everything was run through the clang-format Both run. However the IRQ version dies in MBED after a few touches.
Not related to any changes I made as did not change anything, except the order as I mentioned and it Let me know what you think. |
Here is a test sketch that can do the touchpaint that I am showing in the ArduinoCore-zephyr PR. I modified it such that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I had many comments on the cpp file, so I thought it would just be easier to send you an updated file. See the attached file.
-
Again, please use the name suggested in my first review:
Arduino_GigaDisplayTouchZephyr.cpp
-
I've already formatted the library and renamed the mbed implementation in #15, so please revert any unrelated changes to minimize your diff.
cbcc030
to
54bd49c
Compare
I believe I have all of your changes pulled in now. I rebased off of your updated main branch, and then I have also updated to your changes on the ArduinoCore-zephyr rebuilt and ran with this updated version |
Zephyr: Added in our preliminary support for touch on the display In ArduinoCore-zephyr added a callback to register with the input class. When set it simply forwards the callbacks to this function. Then added some support. We still don't have things like gestures as I don't think the zephyr input class has support for it. Have a simple touch paint sketch (now supporting multiple touches, that appears to work Edit: The header file now combines the two different versions of the class into one. Added #ifdef __MBED__ in the mbed implementation file so that the code would not compile when we are doing zephyr builds clang-format -i of Arduino_GigaDisplayTouchZephyr.cpp clang-format -i Arduino_GigaDisplayTouch.h
Please fix the formatting issues, see https://github.com/arduino-libraries/Arduino_GigaDisplayTouch/actions/runs/16943340161/job/48017964802?pr=14 Otherwise, looks good. |
Zephyr: Added in our preliminary support for touch on the display
In ArduinoCore-zephyr added a callback to register with the input class. When set it simply forwards the callbacks to this function.
Then added some support. We still don't have things like gestures as I don't think the zephyr input class has support for it.
Have a simple touch paint sketch (now supporting multiple touches, that appears to work
Depends on: