Lora support #83

fabik111 · 2019-12-10T16:07:43Z

Support for LoRaWAN boards.
ArduinoIoTCloud has been separated in ArduinoIoTCloudTCP and ArduinoIoTCloudLPWAN handlers to support TCP and Lora connection. ArduinoIoTCloud becomes a pure virtual class.
One of these two object is instantiated according board type

TravisBuddy · 2019-12-10T16:10:42Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 9ae4aa80-1b67-11ea-b9ce-6f43500ed087

TravisBuddy · 2019-12-10T16:28:29Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 17420f30-1b6a-11ea-b9ce-6f43500ed087

TravisBuddy · 2019-12-10T17:13:34Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 62597b60-1b70-11ea-bf43-1b2acb1c8aac

TravisBuddy · 2019-12-10T17:15:58Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: b95df0d0-1b70-11ea-bf43-1b2acb1c8aac

TravisBuddy · 2019-12-11T15:05:00Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 98369e40-1c27-11ea-ba59-e12deadb3a4c

aentinger

So far this PR looks reasonably good. A couple of questions:

Why is there no CloudSerial for LoRa (as far as I know its used for the getting started examples? - how does the LoRa board do that?)
What is the difference between LoRa and WiFi/GSM and does the it justify a separation of the classes?

src/ArduinoIoTCloud.h

src/ArduinoIoTCloudLPWAN.h

src/ArduinoIoTCloudTCP.cpp

TravisBuddy · 2019-12-18T11:04:42Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 2e86ec70-2186-11ea-a044-67124c782b74

fabik111

* Why is there no CloudSerial for LoRa (as far as I know its used for the getting started examples? - how does the LoRa board do that?)

CloudSerial will be not available for LoRa because we have bandwidth limitation and users risk to never send messages with property values but only with logs

* What is the difference between LoRa and WiFi/GSM and does the it justify a separation of the classes?

There are many differences between LoRa and WiFi (p.e. LoRa has not mqtt...), we offer an interface that can be easily inherited for future protocols and can extends Arduino Cloud for other boards

src/ArduinoIoTCloud.cpp

src/ArduinoIoTCloudLPWAN.cpp

TravisBuddy · 2019-12-19T09:40:22Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 914f2da0-2243-11ea-b76a-c509dfe0ae07

src/CloudSerial.cpp

TravisBuddy · 2019-12-19T15:12:55Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 05c8c000-2272-11ea-b76a-c509dfe0ae07

TravisBuddy · 2019-12-19T15:19:32Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f20213e0-2272-11ea-b76a-c509dfe0ae07

TravisBuddy · 2019-12-20T15:02:25Z

Hey @fabik111,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ba1d4590-2339-11ea-8e2a-07cdc06d0399

TravisBuddy · 2020-01-13T09:32:05Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8de19470-35e7-11ea-b480-9fec542541c3

TravisBuddy · 2020-01-16T11:46:24Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d013de00-3855-11ea-b5ea-ed59922799f5

…rduinoIoTCloud_Travis_CI need to be updated too in order to support MKRWAN boards

TravisBuddy · 2020-01-16T15:44:35Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 165c1aa0-3877-11ea-b5ea-ed59922799f5

TravisBuddy · 2020-01-17T13:05:44Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0fe77c60-392a-11ea-b1da-df51646d6421

TravisBuddy · 2020-01-17T14:38:09Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f860eba0-3936-11ea-b1da-df51646d6421

TravisBuddy · 2020-01-27T12:18:06Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 105f4a60-40ff-11ea-a60c-ed450572c3ce

…e codespell help for details)

TravisBuddy · 2020-01-27T13:35:05Z

Travis tests have failed

Hey @fabik111,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d0e4d430-4109-11ea-a60c-ed450572c3ce

This was referenced Dec 10, 2019

LoRa support arduino-libraries/Arduino_ConnectionHandler#11

Merged

LoRa support arduino-libraries/ArduinoCloudThing#48

Merged

aentinger suggested changes Dec 18, 2019

View reviewed changes

fabik111 commented Dec 18, 2019

View reviewed changes

aentinger reviewed Dec 19, 2019

View reviewed changes

src/ArduinoIoTCloud.cpp Outdated Show resolved Hide resolved

aentinger reviewed Dec 19, 2019

View reviewed changes

src/ArduinoIoTCloudLPWAN.cpp Outdated Show resolved Hide resolved

AlbyIanna reviewed Dec 19, 2019

View reviewed changes

src/CloudSerial.cpp Outdated Show resolved Hide resolved

fabik111 and others added 13 commits January 13, 2020 10:28

split lib for TCP and Lora connections

0cab7a7

Lora working

2dd49c0

add property tag

0d14d57

add retry

564ded8

delete not used cpp

a37f8cc

code finalized

8ffff46

fix extern variable

5599540

apply Astyle

1ad8158

fix astyle

9843401

Add RTCZero to ArduinoIoTCloudLPWAN

fa7ae71

refactor addpropertyReal methods

5cf8e50

fix formatting

94e6fc5

update cloudserial #ifdef

f12499c

fabik111 added 2 commits January 13, 2020 10:28

delete comment CloudSerial

9ada633

change ifdef conditions

c2a03b9

fabik111 force-pushed the lora-support branch from 5563800 to c2a03b9 Compare January 13, 2020 09:29

Adding CI build for MKRWAN1310 (probably ArduinoIoTCloud_LED_switch/A…

776e405

…rduinoIoTCloud_Travis_CI need to be updated too in order to support MKRWAN boards

edit sketch for lora boards

4254e47

fix Astyle

3284b64

fix codespell config for WAN

a2970eb

aentinger added 2 commits January 27, 2020 14:21

There is no need to build 'Provisioning.ino' for MKRWAN 1310

c20684b

WAN must be written in lowercase in order to be correctly ignored (se…

103bfde

…e codespell help for details)

aentinger merged commit 2c34b4c into arduino-libraries:master Jan 28, 2020

aentinger deleted the lora-support branch January 28, 2020 14:00

Lora support #83

Lora support #83

Uh oh!

Conversation

fabik111 commented Dec 10, 2019

Uh oh!

TravisBuddy commented Dec 10, 2019

Travis tests have failed

TravisBuddy Request Identifier: 9ae4aa80-1b67-11ea-b9ce-6f43500ed087

Uh oh!

TravisBuddy commented Dec 10, 2019

Travis tests have failed

TravisBuddy Request Identifier: 17420f30-1b6a-11ea-b9ce-6f43500ed087

Uh oh!

TravisBuddy commented Dec 10, 2019

Travis tests have failed

TravisBuddy Request Identifier: 62597b60-1b70-11ea-bf43-1b2acb1c8aac

Uh oh!

TravisBuddy commented Dec 10, 2019

Travis tests have failed

TravisBuddy Request Identifier: b95df0d0-1b70-11ea-bf43-1b2acb1c8aac

Uh oh!

TravisBuddy commented Dec 11, 2019

Travis tests have failed

TravisBuddy Request Identifier: 98369e40-1c27-11ea-ba59-e12deadb3a4c

Uh oh!

aentinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TravisBuddy commented Dec 18, 2019

Travis tests have failed

TravisBuddy Request Identifier: 2e86ec70-2186-11ea-a044-67124c782b74

Uh oh!

fabik111 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TravisBuddy commented Dec 19, 2019

Travis tests have failed

TravisBuddy Request Identifier: 914f2da0-2243-11ea-b76a-c509dfe0ae07

Uh oh!

Uh oh!

TravisBuddy commented Dec 19, 2019

Travis tests have failed

TravisBuddy Request Identifier: 05c8c000-2272-11ea-b76a-c509dfe0ae07

Uh oh!

TravisBuddy commented Dec 19, 2019

Travis tests have failed

TravisBuddy Request Identifier: f20213e0-2272-11ea-b76a-c509dfe0ae07

Uh oh!

TravisBuddy commented Dec 20, 2019

TravisBuddy Request Identifier: ba1d4590-2339-11ea-8e2a-07cdc06d0399

Uh oh!

TravisBuddy commented Jan 13, 2020

Travis tests have failed

TravisBuddy Request Identifier: 8de19470-35e7-11ea-b480-9fec542541c3

Uh oh!

TravisBuddy commented Jan 16, 2020

Travis tests have failed

TravisBuddy Request Identifier: d013de00-3855-11ea-b5ea-ed59922799f5

Uh oh!

TravisBuddy commented Jan 16, 2020

Travis tests have failed

TravisBuddy Request Identifier: 165c1aa0-3877-11ea-b5ea-ed59922799f5

Uh oh!

TravisBuddy commented Jan 17, 2020

Travis tests have failed

TravisBuddy Request Identifier: 0fe77c60-392a-11ea-b1da-df51646d6421

Uh oh!

TravisBuddy commented Jan 17, 2020

Travis tests have failed

TravisBuddy Request Identifier: f860eba0-3936-11ea-b1da-df51646d6421