Skip to content

Adding watchdog for SAMD architecture #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2021
Merged

Adding watchdog for SAMD architecture #235

merged 3 commits into from
Mar 16, 2021

Conversation

aentinger
Copy link
Contributor

Which is continually fed within ArduinoIoTCloud::update() to reset the board in case some function becomes stuck.

… ArduinoIoTCloud::update() to reset the board in case some function becomes stuck.
@aentinger aentinger added the type: enhancement Proposed improvement label Mar 9, 2021
@aentinger aentinger self-assigned this Mar 9, 2021
… code accordingly. Also add watchdog resets within the OTA callback to prevent the watchdog from biting during OTA.
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Mar 10, 2021
@codecov-io
Copy link

codecov-io commented Mar 10, 2021

Codecov Report

Merging #235 (c6f0336) into master (70efc00) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files          24       24           
  Lines         867      867           
=======================================
  Hits          825      825           
  Misses         42       42           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70efc00...c6f0336. Read the comment docs.

@github-actions
Copy link

Memory usage change @ c6f0336

Board flash % RAM for global variables %
arduino:mbed:envie_m4 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 +88 - +528 +0.03 - +0.2 🔺 +4 - +20 +0.01 - +0.06
arduino:samd:mkrgsm1400 🔺 +96 - +536 +0.04 - +0.2 🔺 +4 - +20 +0.01 - +0.06
arduino:samd:mkrnb1500 🔺 +72 - +512 +0.03 - +0.2 🔺 +4 - +4 +0.01 - +0.01
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +528 0.0 - +0.2 🔺 0 - +4 0.0 - +0.01
arduino:samd:nano_33_iot 🔺 0 - +532 0.0 - +0.2 🔺 0 - +8 0.0 - +0.02
esp32:esp32:esp32 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
% examples/ArduinoIoTCloud-Advanced
RAM for global variables
% examples/ArduinoIoTCloud-Basic
flash
% examples/ArduinoIoTCloud-Basic
RAM for global variables
% examples/utility/ArduinoIoTCloud_Travis_CI
flash
% examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
% examples/utility/Provisioning
flash
% examples/utility/Provisioning
RAM for global variables
% examples/utility/SelfProvisioning
flash
% examples/utility/SelfProvisioning
RAM for global variables
%
arduino:mbed:envie_m4 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 520 0.2 20 0.06 528 0.2 20 0.06 504 0.19 4 0.01 88 0.03 20 0.06
arduino:samd:mkrgsm1400 512 0.2 4 0.01 528 0.2 20 0.06 536 0.2 20 0.06 96 0.04 20 0.06
arduino:samd:mkrnb1500 512 0.2 4 0.01 504 0.19 4 0.01 504 0.19 4 0.01 72 0.03 4 0.01
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 528 0.2 4 0.01 520 0.2 4 0.01 520 0.2 4 0.01 88 0.03 4 0.01 0 0.0 0 0.0
arduino:samd:nano_33_iot 532 0.2 8 0.02 524 0.2 8 0.02 524 0.2 8 0.02 92 0.04 8 0.02 0 0.0 0 0.0
esp32:esp32:esp32 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp8266:esp8266:huzzah 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,520,0.2,20,0.06,528,0.2,20,0.06,504,0.19,4,0.01,88,0.03,20,0.06
arduino:samd:mkrgsm1400,512,0.2,4,0.01,528,0.2,20,0.06,536,0.2,20,0.06,96,0.04,20,0.06
arduino:samd:mkrnb1500,512,0.2,4,0.01,504,0.19,4,0.01,504,0.19,4,0.01,72,0.03,4,0.01
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwifi1010,528,0.2,4,0.01,520,0.2,4,0.01,520,0.2,4,0.01,88,0.03,4,0.01,0,0.0,0,0.0
arduino:samd:nano_33_iot,532,0.2,8,0.02,524,0.2,8,0.02,524,0.2,8,0.02,92,0.04,8,0.02,0,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,

@aentinger aentinger merged commit 897a24d into master Mar 16, 2021
@aentinger aentinger deleted the watchdog branch March 16, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants