audioplayers: Rename player-id to playerId as it should be #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ardera
force-pushed
the
fix_audio_player_id
branch
from
7709824 to
78958ed
Compare
|
oof. does that mean the plugin was broken all the time? |
ardera
approved these changes
Jul 3, 2023
Yes, I think so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I used my own fork all this time I didn't notice that during preparations of PR I renamed
playerIdintoplayer-idwhen querying variables from channel 😢Reference:
https://github.com/bluefireteam/audioplayers/blob/51ab6b4a1271c0da635c3cc8fdb475a542018427/packages/audioplayers_linux/linux/audioplayers_linux_plugin.cc#L106