Include timestamps in getCustomColumns() by default, fix tests (use new #[Test] attribute)
#24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukinovec
changed the title
/** @test */ annotations)/** @test */ annotations), include timestamps in getCustomColumns() by default
stancl
changed the title
/** @test */ annotations), include timestamps in getCustomColumns() by defaultgetCustomColumns() by default, fix tests (use new #[Test] attribute)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop timestamps from getting saved in virtual column
Model timestamps have custom columns. When a model with timestamps gets updated, the timestamps get saved in the virtual column, unless they're specified in
getCustomColumns(). This PR adds the default timestamp columns to the defaultgetCustomColumns()method.Fix tests
In some PHPUnit version (likely 10.x, not properly documented though), the
/** @test */annotations no longer work for marking functions in test files as tests. Instead, the function names either have to start withtest(e.g.public function testThatSomethingWorks), or have the#[Test]attribute.This PR deletes the
/** @test */annotations from the tests and makes the tests use the#[Test]attribute instead.