fix: re-export types used by pub api #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarkegz
reviewed
Jul 26, 2025
|
|
||
| use axerrno::AxError; | ||
| use memory_set::MappingError; | ||
| pub use axerrno::AxError; |
There was a problem hiding this comment.
- 使用者不需要去挨个添加这些结构体所在的crate，只用依赖这一个crate.
- 如果依赖这个crate, 这个crate axerrno 版本是 0.1 ， 而自身又要使用 axerrno 0.2, 将会造成不兼容，若其他crate 用了 axerrno 0.3 并且也没重新导出，则更加无法兼容，除非修改所有依赖的crate axerrno 版本，否则无法使用。若都使用重新导出的方式，则 0.1 0.2 0.3 可以共存。可参照 aarch64-cpu crate，重新导出了tock-registors， arceos- 0.9 0.8 0.10 版本的tock-registors 同时存在
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-export the dependency types used by the API, so that users don't have to manage the versions of transitive dependencies, and multiple versions can coexist.