Computed Values support for PUT /_api/collection/collection/properties
#268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aMahanna
commented
Aug 8, 2023
aMahanna
changed the title
/_api/collection/collection/properties/_api/collection/collection/properties
aMahanna
commented
Aug 8, 2023
| schema: Optional[Json] = None, | ||
| replication_factor: Optional[int] = None, | ||
| write_concern: Optional[int] = None, | ||
| computed_values: Optional[Jsons] = None, |
Member
Author
There was a problem hiding this comment.
small nitpick: we have computed_values as the parameter name here, but have computedValues for the create_collection method in database.py:
https://github.com/ArangoDB-Community/python-arango/blob/main/arango/database.py#L977
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 99.01% 99.04% +0.02%
==========================================
Files 26 26
Lines 3958 3960 +2
==========================================
+ Hits 3919 3922 +3
+ Misses 39 38 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computed_valuesparameter for thecollection.configuremethodcomputedValueslogic in theformat.format_collectionmethod to support unspecified attributes in a computedValue object