Skip to content

Re-introduce setuptools-scm with correct usage #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 17, 2022
Merged

Re-introduce setuptools-scm with correct usage #206

merged 6 commits into from
Jun 17, 2022

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Jun 13, 2022 •
edited
Loading

What's new

  • Re-introduces the auto-versioning mechanic provided by setuptools-scm via pyproject.toml (instead of setup.py)

Some notes:

  • Usage of setuptools-scm via setup.py has been deprecated in favour of pyproject.toml
  • arango/version.py has been deleted & reintroduced to the .gitignore file

aMahanna added 4 commits June 13, 2022 19:37
@aMahanna
initial commit
acab36d
@aMahanna
attempt fix: mypy
0055d59
@aMahanna
attempt fix: importlib-metadata version()
adffec8 
Package import statements defer between Python < 3.8 and Python >= 3.8
@aMahanna
set: warn_unused_ignores to false
65cd537 
This is probably the cleanest option, at the cost of silencing this warning repo-wide. Issue: python/mypy#8823
aMahanna
aMahanna commented Jun 14, 2022
View reviewed changes
aMahanna
aMahanna commented Jun 14, 2022
View reviewed changes
@aMahanna aMahanna self-assigned this Jun 14, 2022
@aMahanna aMahanna mentioned this pull request Jun 14, 2022
Closed
@aMahanna aMahanna requested a review from joowani June 14, 2022 19:32
@aMahanna
Copy link
Member Author

aMahanna commented Jun 15, 2022 •
edited
Loading

Currently trying to replace importlib-metadata with pkg_resources, but encountering mypy-related issues locally

@arangodb arangodb deleted a comment from codecov-commenter Jun 16, 2022
joowani
joowani approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@joowani joowani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

@joowani joowani changed the title setuptools-scm without setup.py Re-introduce setuptools-scm with correct usage Jun 17, 2022
@joowani joowani merged commit 21c9e5d into main Jun 17, 2022
@joowani joowani deleted the feature/setuptools-scm-fix branch June 17, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@joowani joowani joowani approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@aMahanna aMahanna

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aMahanna @joowani