Fix missing types #17
Merged
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .gitignore is used as a fallback whne publishing to exclude files to NPM[^1]. As such, the types were not included in the release. This PR removes the .gitignore to match the web SDK repo and allow the types to be published to NPM. [^1]: https://docs.npmjs.com/cli/v9/configuring-npm/package-json#files
|
I see. |
lohanidamodar
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The .gitignore is used as a fallback whne publishing to exclude files to NPM1. As such, the types were not included in the release.
Compare the code on NPM between react-native-appwrite and appwrite:
This PR removes the .gitignore to match the web SDK repo and allow the types to be published to NPM.
Fixes #16
Test Plan
Manual
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes
Footnotes
https://docs.npmjs.com/cli/v9/configuring-npm/package-json#files ↩