-
Notifications
You must be signed in to change notification settings - Fork 147
feat: Flutter SDK update for version 20.3.2 #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request introduces extensions to the Avatars service by adding a new Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🔇 Additional comments (1)
CHANGELOG.md (1)
3-11: Verify semantic versioning aligns with feature scope.Adding new public methods and enums to the API surface is typically a feature addition, which warrants a minor version bump (20.4.0) rather than a patch release (20.3.2). Patch releases conventionally contain only bug fixes. If these features are intended as part of 20.3.2, confirm this is the maintainers' intentional versioning strategy; otherwise, consider bumping to 20.4.0.
| * Add `getScreenshot` method to `Avatars` service | ||
| * Add `Theme`, `Timezone` and `Output` enums |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read the CHANGELOG.md file to see the exact placement of lines 10-11
cat -n CHANGELOG.md | head -20Repository: appwrite/sdk-for-flutter
Length of output: 852
The verification confirms the original review comment is accurate. The entries at lines 10-11 are indeed placed under the 20.3.1 section, while the PR title indicates this is a 20.3.2 release. This creates a clear mismatch that needs correction.
Move changelog entries to version 20.3.2 section.
The new feature entries (getScreenshot method and enums) are documented under version 20.3.1, but the PR title indicates this is a version 20.3.2 release. This mismatch creates confusion about which version actually contains these features.
Apply this diff to move the entries to the correct section:
## 20.3.2
* Fix OAuth2 browser infinite redirect issue
+* Add `getScreenshot` method to `Avatars` service
+* Add `Theme`, `Timezone` and `Output` enums
## 20.3.1
* Fix passing of `null` values and stripping only non-nullable optional parameters from the request body
-* Add `getScreenshot` method to `Avatars` service
-* Add `Theme`, `Timezone` and `Output` enumsCommittable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 10 to 11, the two entries ("Add `getScreenshot`
method to `Avatars` service" and "Add `Theme`, `Timezone` and `Output` enums")
are incorrectly placed under the 20.3.1 section while the PR is for 20.3.2; move
those two bullet lines out of the 20.3.1 section and insert them under the
20.3.2 section (create the 20.3.2 header if it does not exist), preserving
bullet formatting and surrounding spacing so the changelog shows the entries
under version 20.3.2.
This PR contains updates to the Flutter SDK for version 20.3.2.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.