Skip to content

Conversation

@czechboy0
Copy link
Contributor

@czechboy0 czechboy0 commented Dec 14, 2023

Motivation

Land changes approved in apple/swift-openapi-generator#495.

Modifications

Introduced the new APIs.

Result

Easy use of event streams.

Test Plan

Added unit tests for all.

@czechboy0 czechboy0 changed the title [WIP] Event streams sequences Event streams sequences Jan 5, 2024
@czechboy0 czechboy0 changed the title Event streams sequences [Runtime] SOAR-0010: Event streams sequences Jan 5, 2024
@czechboy0 czechboy0 marked this pull request as ready for review January 5, 2024 12:42
@czechboy0 czechboy0 merged commit 6be221f into apple:main Jan 8, 2024
@czechboy0 czechboy0 deleted the hd-event-streams branch January 8, 2024 14:07
@czechboy0 czechboy0 added the 🆕 semver/minor Adds new public API. label Jan 8, 2024
czechboy0 added a commit to apple/swift-openapi-generator that referenced this pull request Jan 8, 2024
### Motivation

Example projects for
apple/swift-openapi-runtime#91.

### Modifications

Added examples.

### Result

N/A

### Test Plan

N/A
@AFutureD
Copy link

Hi @czechboy0 , I wonder why ServerSentEvent need to conform to Hashable?

@czechboy0
Copy link
Contributor Author

Hi @AFutureD - can you elaborate on what's behind that question? Is the Hashable conformance limiting your use of it?

@AFutureD
Copy link

Hi @czechboy0 , Thanks for quick resposne.

In ServerSentEventWithJSONData, the generic JSONDataType may not guaranteed to conform to Hashable.

For example, there are a lot of packages can be found on GitHub for JsonSchema, and they all do not conform to Hashable.

And, the decoder or deserializer may not need Hashable constraint.

@czechboy0
Copy link
Contributor Author

That's a good point. Please file a new issue where we can discuss this further.

@AFutureD
Copy link

Discussion continues on apple/swift-openapi-generator#793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🆕 semver/minor Adds new public API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants