Skip to content

Reduce deployment targets by 3 versions #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Reduce deployment targets by 3 versions #18

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37849df
Reduce deployment targets by 3 versions
Jun 12, 2023
2af23b4
Address PR feedback
Jun 13, 2023
afe9082
Address PR feedback
Jun 13, 2023
74366db
Update Sources/OpenAPIRuntime/Conversion/Converter+Client.swift
andrewse02 Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import PackageDescription
let package = Package(
name: "swift-openapi-runtime",
platforms: [
.macOS(.v13), .iOS(.v16), .tvOS(.v16), .watchOS(.v9),
.macOS(.v10_15), .iOS(.v12), .tvOS(.v13), .watchOS(.v6),
],
products: [
.library(
Expand Down
20 changes: 15 additions & 5 deletions Sources/OpenAPIRuntime/Conversion/Converter+Client.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,21 @@ extension Converter {
) throws -> String {
var renderedString = template
for parameter in parameters {
renderedString.replace(
"{}",
with: parameter.description,
maxReplacements: 1
)
if #available(iOS 16.0, macOS 13.0, *) {
renderedString.replace(
"{}",
with: parameter.description,
maxReplacements: 1
)
} else {
if let range = renderedString.range(of: "{}") {
renderedString = renderedString.replacingOccurrences(
of: "{}",
with: parameter.description,
range: range
)
}
}
}
return renderedString
}
Expand Down