Custom JSON encoding options #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjbeaumont
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Thanks @czechboy0, LGTM.
I think this is probably the most pragmatic approach for now. We can always revisit a full-blown encoder abstraction in the future when there's a real need for it.
simonjbeaumont
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A second attempt at apple/swift-openapi-generator#605, this time less open-ended than #111.
Only allow customizing the JSON encoding options.
Modifications
JSONEncodingOptionsoption set.Configurationstruct.Result
Allows users to customize the JSON encoding options.
Test Plan
Added unit tests.