[Generator] Support unexploded query items #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
approved these changes
Aug 7, 2023
Contributor
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
From what I can tell, this all looks good. It might be worth getting some eyes with more knowledge of this project to look as well 👀
Sources/_OpenAPIGeneratorCore/Translator/Parameters/TypedParameter.swift
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the review, @glbrntt, could you also take a look at the associated runtime PR please? apple/swift-openapi-runtime#35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Depends on apple/swift-openapi-runtime#35.
Fixes #52.
By default, query items are encoded as exploded (
key=value1&key=value2), but OpenAPI allows explicitly requesting them unexploded (key=value1,value2). This feature missing has shown up in a few OpenAPI documents recently.Modifications
Adapt the generator to provide the two new
styleandexplodeparameters to query item encoding/decoding functions.Result
We now support unexploded query items.
Test Plan
Expanded snippet-based tests to allow generating not just types, but also parts of the client/server. This has allowed us to not have to expand file-based reference tests here.