Convert WebSocket URLRequest to RFC8441 HTTPRequest #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekinnear
approved these changes
Jun 10, 2025
Lukasa
approved these changes
Sep 10, 2025
guoye-zhang
force-pushed
the
websocket
branch
from
43d6a45 to
808b018
Compare
Lukasa
approved these changes
Sep 22, 2025
|
@swift-ci please test |
|
@Lukasa It appears that |
|
Done, rerunning CI now. |
auto-merge was automatically disabled
October 5, 2025 18:08
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebSocket uses the extended-CONNECT form in HTTP/2 and HTTP/3. When creating an HTTPRequest from a URLRequest, we should translate it into the new form.
:method:GET->CONNECT:scheme:wss/ws->https/http:protocol:websocketHTTPTypes defaults to modern HTTP versions, and the expectation is that the HTTP/1 serializer has to translate the extended-CONNECT request back to the old request form.