Skip to content

Conform SpanStatus to Equatable #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

Conform SpanStatus to Equatable #46

merged 1 commit into from
Apr 1, 2021

Conversation

slashmo
Copy link
Collaborator

@slashmo slashmo commented Mar 29, 2021

It would be nice to have SpanStatus conform to Equatable for easier testing.

@slashmo slashmo requested a review from ktoso March 29, 2021 18:19
@slashmo slashmo self-assigned this Mar 29, 2021
@ktoso ktoso removed the 0 - new label Apr 1, 2021
ktoso
ktoso approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me 👍

Would you want a patch release?

@ktoso ktoso merged commit df632ad into apple:main Apr 1, 2021
@slashmo slashmo deleted the equatable-span-status branch April 1, 2021 11:59
@slashmo
Copy link
Collaborator Author

slashmo commented Apr 1, 2021

Would you want a patch release?
@ktoso

No hurry on my end. I think we can wait until #45 is closed (which I'll work on soon), and combine both in a patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

Assignees

@slashmo slashmo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slashmo @ktoso