-
Notifications
You must be signed in to change notification settings - Fork 51
fixing docs #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fixing docs #198
Conversation
…eprecation summary to redirect readers to correct API for deprecated versions
…t lint checking them for documentation
|
The last commit in this changes a a number of access levels for properties and types in the Test module. Applying the documentation check applies broadly where-ever the swift-format lint command is triggered, and the current GitHub-workflows script for soundness looks for all .swift files in the repo, and doesn't distinguish between Tests and Sources. I think that's a reasonable adjustment to support the existing moving parts, but happy to revisit and pull off that last commit if that's not desired. |
Package.swift
Outdated
| dependencies: [ | ||
| .package(url: "https://github.com/apple/swift-service-context.git", from: "1.1.0") | ||
| .package(url: "https://github.com/apple/swift-service-context.git", from: "1.1.0"), | ||
| .package(url: "https://github.com/swiftlang/swift-docc-plugin", from: "1.0.0"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the docc plugin again, we generally just let CI scripts add it temporarily, but don't have it in other packages like Swift Log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 darnit - sorry, I know better
resolves #182