Tracer.withSpan's isolation param should be 'isolated' #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Motivation:** The intent of this parameter is to not cross an isolation boundary when calling withSpan, thus, we were missing the isolated modifier in this protocol. **Modifications:** Make the `isolation: (any Actor)? = #isolation,` parameter 'isolated', as was originally intended **Result:** Not crossing actor boundary when calling this method means less errors when adopting Swift 6 mode, and correct behavior of these functions
ktoso
added
🔨 semver/patch
czechboy0
approved these changes
Jun 18, 2025
|
Gonna tag a patch with this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The intent of this parameter is to not cross an isolation boundary when calling withSpan, thus, we were missing the isolated modifier in this protocol.
Modifications:
Make the
isolation: (any Actor)? = #isolation,parameter 'isolated', as was originally intendedResult:
Not crossing actor boundary when calling this method means less errors when adopting Swift 6 mode, and correct behavior of these functions
rdar://153688123