Bump minimum Swift version to 5.7 #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Now that Swift 5.9 is GM we should update the supported versions and remove 5.6 Modifications: * Update `Package.swift` * Remove guards for swift <5.7 * Add deprecation annotations to `LegacyTracer` API * Delete the 5.6 docker compose file and make a 5.10 one * Update docs Result: Remove support for Swift 5.6, add 5.10
|
@swift-server-bot add to allowlist |
|
CI updated. @swift-server-bot test this please |
|
@swift-server-bot test this please |
|
Ok all jobs failing here due to warnings as errors etc. I'll look into addressing this soon -- unless you're still up for it @rnro ? |
ktoso
approved these changes
Feb 1, 2024
|
I'll handle this -- the fallout is the deprecation warnings since we have warnings as errors... |
|
Done, thank you! I'll call a 1.1.0 with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Now that Swift 5.9 is GM we should update the supported versions and remove 5.6
Modifications:
Package.swiftLegacyTracerAPIResult:
Remove support for Swift 5.6, add 5.10