Skip to content

Remove print from implementation of combineLatest #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,6 @@ struct CombineLatestStateMachine<
}

mutating func elementProduced(_ result: (Base1.Element?, Base2.Element?, Base3.Element?)) -> ElementProducedAction? {
print("upstream produced: \(result)")
switch self.state {
case .initial:
// Child tasks that are producing elements are only created after we transitioned to `zipping`
Expand Down Expand Up @@ -375,7 +374,6 @@ struct CombineLatestStateMachine<
}

mutating func upstreamFinished(baseIndex: Int) -> UpstreamFinishedAction? {
print("upstream finished: \(baseIndex)")
switch self.state {
case .initial:
preconditionFailure("Internal inconsistency current state \(self.state) and received upstreamFinished()")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ final class CombineLatestStorage<
}
}

print("Returning: \(result)")
return try result._rethrowGet()

} onCancel: {
Expand Down