Rework combineLatest to remove the Sendable constraint on the base iterator
#228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e iterator # Motivation This follows the recent rework of the `merge` and `zip` algorithms where we dropped the `Sendable` constraint on the `BaseX.AsyncIterator`. This PR now removes the same constraint on `combineLatest`. # Modification This PR overhauls the implementation of `combineLatest` with the goal of changing these things: - Drop the `Sendable` constraint of the base `AsyncIterator`s - Only create a single `Task` # Result `combineLatest` now doesn't require the base `AsyncIterator` to be `Sendable`
phausler
reviewed
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This follows the recent rework of the
mergeandzipalgorithms where we dropped theSendableconstraint on theBaseX.AsyncIterator. This PR now removes the same constraint oncombineLatest.Modification
This PR overhauls the implementation of
combineLatestwith the goal of changing these things:Sendableconstraint of the baseAsyncIteratorsTaskResult
combineLatestnow doesn't require the baseAsyncIteratorto beSendable